Proposal: Email mechanism #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsheff
reviewed
Mar 23, 2017
| @@ -461,6 +469,12 @@ def run(self, cmd, target=None, lock_name=None, shell="guess", nofail=False, cle | |||
| # in your pipeline can depend on this since it won't be run if that command # isn't required because target exists. | |||
| return process_return_code | |||
|
|
|||
|
|
|||
| @staticmethod | |||
| def _likely_shell(cmd): | |||
|
Yes, this has been on my to-do list for awhile. Now expand this to a larger vision: Instead of a report_result would use the notify class to insert into a database, or whatever; failures would trigger an e-mail (and insert into the db). a web interface displays job running status. PipelineManager contructor takes an optional Notifier object at instantiation. Notifier is created by the pipeline and linked to project-config or looperenv variables. |
Merged
|
OK, closing in favor of #29 since this is broader-scope |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would need some additional handling of SMTP and then hooks into
PipelineManagermethods (fail_pipelineand/or_exit_handler?) but I wanted to see if this is viable. It'd be nice to be notified automatically when something completes and/or fails early without checking manually.