feat: reexport shadcn components and theme #2
Conversation
MarioCadenas
force-pushed
the
ui-components
branch
2 times, most recently
from
6ebcef4 to
7c5ae71
Compare
MarioCadenas
force-pushed
the
ui-components
branch
from
7c5ae71 to
d053b4f
Compare
chore: fixup
MarioCadenas
force-pushed
the
ui-components
branch
from
d053b4f to
c20a0f7
Compare
|
BTW it would be great to have some kind of storybook for the components 🤔 I'm actually surprised the shadcn doesn't provide this out of the box but maybe we can reuse some 3rd party registry (like https://github.com/lloydrichards/shadcn-storybook-registry - but probably this is not for us as it's v3). What do you think? |
well they don't have a storybook but the shadcn page itself is basically like one https://ui.shadcn.com/docs/components I don't know if we need that for us, what do you see it would be useful for? |
|
As long as the components are 1:1 the same we don't need it badly, but once we do some patches/changes, I believe it would be great to have it up to date for users (humans) for documentation purposes 👍 Also, even if we don't patch them, having a single place with App Kit documentation would be beneficial. But it is rather nice to have, external links are fine for now 👍 |
## Changes <!-- Brief summary of your changes that is easy to understand --> Remove all shadcn components and consume them from `@databricks/appkit-ui/react` This [PR](databricks/appkit#2) would need to be merged first. ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> We reexport all the components from the library and provide a base theming, allowing users to easily customize the theme by simply changing the colors in the `index.css` file ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. --> Co-authored-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
This PR reexports all shadcn components prepared to be easily themed + with dark/light mode out of the box.
To change the colors we only need to modify the variables in the index.css file
This shows the playground using the components plus the base theme
Dark mode
Light mode
