Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the AppKit type-generator to always emit a valid query schema/type (even when DESCRIBE QUERY fails or returns no columns) and introduces a cache retry flag to re-attempt schema generation later.
Changes:
- Update
convertToQueryTypeto return{ type, hasResults }and emitresult: unknownwhen no columns are present. - Ensure
generateQueriesFromDescribeincludes failed queries in output and cache (markedretry: true), and persists cache incrementally to survive partial failures. - Bump cache version to
2and update tests to cover new behaviors (unknown result types, partial failures, cache writes,hasResults).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/appkit/src/type-generator/query-registry.ts | Core logic changes: unknown result fallback, retry-aware cache usage, incremental caching, new return shape for convertToQueryType. |
| packages/appkit/src/type-generator/cache.ts | Cache schema bumped to v2 with retry field; adds warning log on load failures. |
| packages/appkit/src/type-generator/tests/query-registry.test.ts | Updates tests for new convertToQueryType return value and adds hasResults coverage. |
| packages/appkit/src/type-generator/tests/generate-queries.test.ts | Expands tests to ensure failed queries still produce schemas, unknown result types, and cache writes occur per query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
calvarjorge
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array< ; >bugappKitTypes.d.tsfrom ESLint configQueryRegistrycache to addretry: booleanNew Behavior:
When a describe query fails, query result will be typed as
unknownand cache will haveretry: trueflag. Also, query builder will log which carries are a cache HIT when which weren't. And in case a certain describe fails, it will log the error from the server.closes #125