Agent review

Author: janniklasrose

…/genie_space/test_genie_space.genie.json …e_space/test_genie_space.geniespace.jsonacceptance/bundle/generate/genie_space/out/genie_space/test_genie_space.genie.json renamed to acceptance/bundle/generate/genie_space/out/genie_space/test_genie_space.geniespace.json acceptance/bundle/generate/genie_space/out/genie_space/test_genie_space.genie.json renamed to acceptance/bundle/generate/genie_space/out/genie_space/test_genie_space.geniespace.json

@@ -3,6 +3,6 @@ resources:
     test_genie_space:
       title: "test genie space"
       warehouse_id: test-warehouse-id
-      file_path: ../genie_space/test_genie_space.genie.json
+      file_path: ../genie_space/test_genie_space.geniespace.json
       description: test description
       parent_path: /Workspace/test-[UNIQUE_NAME]

acceptance/bundle/generate/genie_space/out/resource/test_genie_space.genie_space.yml

@@ -2,5 +2,5 @@
 >>> [CLI] workspace mkdirs /Workspace/test-[UNIQUE_NAME]
 
 >>> [CLI] bundle generate genie-space --existing-id [GENIE_SPACE_ID] --genie-space-dir out/genie_space --resource-dir out/resource
-Writing genie space to out/genie_space/test_genie_space.genie.json
+Writing genie space to out/genie_space/test_genie_space.geniespace.json
 Writing configuration to out/resource/test_genie_space.genie_space.yml

acceptance/bundle/generate/genie_space/output.txt

@@ -8,12 +8,19 @@
       "action": "skip",
       "remote_state": {
         "description": "Inline serialized_space test",
+        "etag": "1",
         "serialized_space": "{\"config\":{\"sample_questions\":[{\"id\":\"sq-001\",\"question\":[\"What is the total revenue?\"]}]},\"data_sources\":{\"tables\":[{\"column_configs\":[{\"column_name\":\"amount\",\"get_example_values\":true}],\"identifier\":\"main.sales.orders\"}]},\"version\":1}",
         "space_id": "[GENIE_SPACE_ID]",
         "title": "Sales Analytics Inline Genie",
         "warehouse_id": "test-warehouse-id"
       },
       "changes": {
+        "etag": {
+          "action": "skip",
+          "reason": "custom",
+          "old": "1",
+          "remote": "1"
+        },
         "parent_path": {
           "action": "skip",
           "reason": "input_only",

acceptance/bundle/resources/genie_spaces/inline/out.plan.json

@@ -1,10 +1,6 @@
 Local = true
 RecordRequests = false
 
-# Genie spaces only support direct deployment engine (no Terraform provider yet)
-[EnvMatrix]
-DATABRICKS_BUNDLE_ENGINE = ["direct"]
-
 Ignore = [
     "databricks.yml",
 ]

acceptance/bundle/resources/genie_spaces/inline/out.test.toml

@@ -0,0 +1,10 @@
+bundle:
+  name: recreate-genie-space-$UNIQUE_NAME
+
+resources:
+  genie_spaces:
+    recreate_target:
+      title: "Recreate Target"
+      warehouse_id: "test-warehouse-id"
+      parent_path: PARENT_PATH_PLACEHOLDER
+      serialized_space: "{}"

acceptance/bundle/resources/genie_spaces/inline/test.toml

@@ -0,0 +1,21 @@
+
+>>> [CLI] bundle deploy
+Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/recreate-genie-space-[UNIQUE_NAME]/default/files...
+Deploying resources...
+Updating deployment state...
+Deployment complete!
+
+=== Plan after changing parent_path should show recreate
+>>> [CLI] bundle plan
+recreate genie_spaces.recreate_target
+
+Plan: 1 to add, 0 to change, 1 to delete, 0 unchanged
+
+>>> [CLI] bundle destroy --auto-approve
+The following resources will be deleted:
+  delete resources.genie_spaces.recreate_target
+
+All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/recreate-genie-space-[UNIQUE_NAME]/default
+
+Deleting files...
+Destroy complete!

acceptance/bundle/resources/genie_spaces/parent_path_recreate/databricks.yml.tmpl

@@ -0,0 +1,14 @@
+cleanup() {
+    trace $CLI bundle destroy --auto-approve
+}
+trap cleanup EXIT
+
+# Deploy with the original parent_path.
+envsubst < databricks.yml.tmpl | sed "s|PARENT_PATH_PLACEHOLDER|/Users/$CURRENT_USER_NAME/genie-old|" > databricks.yml
+trace $CLI bundle deploy
+
+# Change parent_path. parent_path is recreate_on_changes in resources.yml,
+# so the plan should show a recreate (delete + create) rather than an update.
+envsubst < databricks.yml.tmpl | sed "s|PARENT_PATH_PLACEHOLDER|/Users/$CURRENT_USER_NAME/genie-new|" > databricks.yml
+title "Plan after changing parent_path should show recreate"
+trace $CLI bundle plan