disable compression if cloud fetch is enabled #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam2680
requested review from
andrefurlan-db,
benc-db,
rcypher-databricks,
superdupershant and
yunbodeng-db
as code owners
shivam2680
changed the title
|
|
||
| if (ProtocolVersion.supportsArrowCompression(this.serverProtocolVersion) && request.canDownloadResult !== true) { | ||
| request.canDecompressLZ4Result = (options.useLZ4Compression ?? clientConfig.useLZ4Compression) && Boolean(LZ4); | ||
| } |
Collaborator
There was a problem hiding this comment.
should we add a debug log mentioning that even though LZ4 is set we're disabling it as cloud fetch is enabled?
Contributor
Author
There was a problem hiding this comment.
Not sure if this is a good idea to expose internal limitations. Whether data is downloaded in compressed or uncompressed in internal.
jackyhu-db
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable compression if cloud fetch is enabled.
Reason:
Transient issue
Error: Error: Invalid stream checksum: A9A9B8E @17257 at Decoder.emit_Errorwhen running cloud fetch query on sql warehouseJustification:
Minimal impact(~3% on 500MB) result set.
Testing
Unit tests
e2e test