add better parameter validation for KIFEst #116
Conversation
yogeshg
commented
Apr 11, 2018
yogeshg
commented
- check if un-tunable parameters need to be defined
- check if tunable parameters need to be defined or specified in param map (this check against all those given to fitMultiple)
- add test to see if method works correctly
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 83.45% 83.76% +0.31%
==========================================
Files 34 34
Lines 1994 1989 -5
Branches 44 44
==========================================
+ Hits 1664 1666 +2
+ Misses 330 323 -7
Continue to review full report at Codecov.
|
| shutil.rmtree(self.temp_dir, ignore_errors=True) | ||
|
|
||
| def test_validate_params(self): | ||
| """Test that `KerasImageFileEstimator._validateParams` method works as expected""" |
There was a problem hiding this comment.
we probably could be more thorough in making sure all the intersect/diff logic works but I think it's good enough.
sueann
left a comment
sueann
left a comment
There was a problem hiding this comment.
lgtm. just a small comment
| raise ValueError("Output column must be defined") | ||
| if self.inputCol in paramMap: | ||
| raise ValueError("Input column can not be fine tuned") | ||
| model_params = [self.kerasOptimizer, self.kerasLoss, self.kerasFitParams] |
There was a problem hiding this comment.
merge model_params and output_params into tunable_params for clarity
|
Offline review with @smurching , add error for untunable param. raised raised #117 in case this becomes a blocker and we are good with merging as is. |
3 participants
