Skip test that fails due to insufficient permission to create schema #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #358 |
JCZuurmond
force-pushed
the
fix/failing-integration-test-test-dashboard-creates-dashboard-with-replace-database
branch
from
a83cb45 to
ae72e5f
Compare
nfx
approved these changes
Aug 13, 2024
JCZuurmond
force-pushed
the
fix/failing-integration-test-test-dashboard-creates-dashboard-with-replace-database
branch
from
ae72e5f to
3c7f39e
Compare
|
✅ 34/34 passed, 6 flaky, 3 skipped, 13m57s total Flaky tests:
Running from acceptance #349 |
nfx
deleted the
fix/failing-integration-test-test-dashboard-creates-dashboard-with-replace-database
branch
nfx
added a commit
that referenced
this pull request
Aug 13, 2024
* Removed deploy_dashboard method ([#240](#240)). In this release, the `deploy_dashboard` method has been removed from the `dashboards.py` file and the legacy deployment method has been deprecated. The `deploy_dashboard` method was previously used to deploy a dashboard to a workspace, but it has been replaced with the `create` method of the `lakeview` attribute of the WorkspaceClient object. Additionally, the `test_dashboards_creates_dashboard_via_legacy_method` method has been removed. A new test has been added to ensure that the `deploy_dashboard` method is no longer being used, utilizing the `deprecated_call` function from pytest to verify that calling the method raises a deprecation warning. This change simplifies the code and improves the overall design of the system, resolving issue [#232](#232). The `_with_better_names` method and `create_dashboard` method remain unchanged. * Skip test that fails due to insufficient permission to create schema ([#248](#248)). A new test function, `test_dashboards_creates_dashboard_with_replace_database`, has been added to the open-source library, but it is currently marked to be skipped due to missing permissions to create a schema. This function creates an instance of the `Dashboards` class with the `ws` parameter, creates a dashboard using the `make_dashboard` function, and performs various actions using the created dashboard, as well as functions such as `tmp_path` and `sql_backend`. This test function aims to ensure that the `Dashboards` class functions as expected when creating a dashboard with a replaced database. Once the necessary permissions for creating a schema are acquired, this test function can be enabled for further testing and validation. * Updates to use the Databricks Python sdk 0.30.0 ([#247](#247)). In this release, we have updated the project to use Databricks Python SDK version 0.30.0. This update includes changes to the `execute` and `fetch_value` functions, which now use the new `StatementResponse` type instead of `ExecuteStatementResponse`. A conditional import statement has been added to maintain compatibility with both Databricks SDK versions 0.30.0 and below. The `execute` function now raises `TimeoutError` when the specified timeout is greater than 50 seconds and the statement execution hasn't finished. Additionally, the `fetch_value` function has been updated to handle the case when the `execute` function returns `None`. The unit test file `test_backends.py` has also been updated to reflect these changes, with multiple test functions now using the `StatementResponse` class instead of `ExecuteStatementResponse`. These changes improve the system's compatibility with the latest version of the Databricks SDK, ensuring that the core functionality of the SDK continues to work as expected.
Merged
nfx
added a commit
that referenced
this pull request
Aug 13, 2024
* Removed deploy_dashboard method ([#240](#240)). In this release, the `deploy_dashboard` method has been removed from the `dashboards.py` file and the legacy deployment method has been deprecated. The `deploy_dashboard` method was previously used to deploy a dashboard to a workspace, but it has been replaced with the `create` method of the `lakeview` attribute of the WorkspaceClient object. Additionally, the `test_dashboards_creates_dashboard_via_legacy_method` method has been removed. A new test has been added to ensure that the `deploy_dashboard` method is no longer being used, utilizing the `deprecated_call` function from pytest to verify that calling the method raises a deprecation warning. This change simplifies the code and improves the overall design of the system, resolving issue [#232](#232). The `_with_better_names` method and `create_dashboard` method remain unchanged. * Skip test that fails due to insufficient permission to create schema ([#248](#248)). A new test function, `test_dashboards_creates_dashboard_with_replace_database`, has been added to the open-source library, but it is currently marked to be skipped due to missing permissions to create a schema. This function creates an instance of the `Dashboards` class with the `ws` parameter, creates a dashboard using the `make_dashboard` function, and performs various actions using the created dashboard, as well as functions such as `tmp_path` and `sql_backend`. This test function aims to ensure that the `Dashboards` class functions as expected when creating a dashboard with a replaced database. Once the necessary permissions for creating a schema are acquired, this test function can be enabled for further testing and validation. * Updates to use the Databricks Python sdk 0.30.0 ([#247](#247)). In this release, we have updated the project to use Databricks Python SDK version 0.30.0. This update includes changes to the `execute` and `fetch_value` functions, which now use the new `StatementResponse` type instead of `ExecuteStatementResponse`. A conditional import statement has been added to maintain compatibility with both Databricks SDK versions 0.30.0 and below. The `execute` function now raises `TimeoutError` when the specified timeout is greater than 50 seconds and the statement execution hasn't finished. Additionally, the `fetch_value` function has been updated to handle the case when the `execute` function returns `None`. The unit test file `test_backends.py` has also been updated to reflect these changes, with multiple test functions now using the `StatementResponse` class instead of `ExecuteStatementResponse`. These changes improve the system's compatibility with the latest version of the Databricks SDK, ensuring that the core functionality of the SDK continues to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can enable later, ignoring it for now as it is noise in the CI