Skip to content

Fix dataclass field types #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfx merged 4 commits into from
Aug 29, 2024
Merged

Fix dataclass field types #257

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
815d173
work around Python reflection issue
ericvergnaud Aug 9, 2024
c8532c0
Merge branch 'main' into fix-dataclass-field-types
ericvergnaud Aug 26, 2024
fea6deb
formatting
ericvergnaud Aug 27, 2024
ea6d1a1
Merge branch 'main' into fix-dataclass-field-types
ericvergnaud Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/databricks/labs/lsql/backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ def _schema_for(cls, klass: Dataclass):
fields = []
for f in dataclasses.fields(klass):
field_type = f.type
# workaround rare (Python?) issue where f.type is the type name instead of the type itself
# this seems to happen when the dataclass is first used from a file importing it
if isinstance(field_type, str):
try:
field_type = __builtins__[field_type]
except TypeError as e:
logger.warning(f"Could not load type {field_type}", exc_info=e)
if isinstance(field_type, UnionType):
field_type = field_type.__args__[0]
if field_type not in cls._builtin_type_mapping:
Expand Down