Refactor SplitPart expression #1415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvergnaud
suggested changes
Jan 9, 2025
Contributor
ericvergnaud
left a comment
ericvergnaud
left a comment
There was a problem hiding this comment.
This PR needs to move to remorph-community-transpiler
Collaborator
|
@ericvergnaud Eventually, it will, I think, given the interdependency between reconcile depending on custom dialects, we will have to keep this operational within this repo. |
Collaborator
@gueniai Any thoughts? |
Collaborator
|
moved to RCT |
auto-merge was automatically disabled
May 19, 2025 03:13
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
local_expression.SplitPartand refactored to sqlglotexpression.SplitPart.Closes #1411