Only install LSP add-ons if requested #1480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 13/13 passed, 1 skipped, 10s total Running from acceptance #380 |
| ) -> RemorphConfigs: | ||
| self.install_rct() | ||
| self.install_morpheus() | ||
| if module in {"transpiler", "all"}: |
Collaborator
There was a problem hiding this comment.
I covered during the hotfix, I have handled it differently.
Contributor
Author
There was a problem hiding this comment.
Not sure re-running install tasks during config is good ? Do you not prefer the fix in this PR ?
This was referenced Mar 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
This PR includes #1480 It fixes various issues where `install transpile` would crash if external requirements were not met, such as access to pypi and maven, or availability of required packages.
Collaborator
|
@ericvergnaud Can we close I think I rebased this branch on to my hotfix branch |
Contributor
Author
|
Already merged, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current code attempts to install LSP add-ons as part of installing Remorph. This could fail the entire install if not successful.
This PR ensures that installing LSP add-ons is only attempted when explicitly requested.