Skip to content

use dedicated advice code for unsupported sql #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024
Merged

use dedicated advice code for unsupported sql #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e970d6
use dedicated advice message for unsupported sql
ericvergnaud Jul 2, 2024
47fb7f8
fix failing test + formatting
ericvergnaud Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/source_code/linters/dbfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def lint(self, code: str) -> Iterable[Advice]:
except SqlParseError as e:
logger.debug(f"Failed to parse SQL: {code}", exc_info=e)
yield Failure(
code='dbfs-query',
code='dbfs-query-unsupported-sql',
message=f"SQL query is not supported yet: {code}",
# SQLGlot does not propagate tokens yet. See https://github.com/tobymao/sqlglot/issues/3159
start_line=0,
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/source_code/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def lint(self, code: str) -> Iterable[Advice]:
except SqlParseError as e:
logger.debug(f"Failed to parse SQL: {code}", exc_info=e)
yield Failure(
code='table-migrate',
code='sql-query-unsupported-sql',
message=f"SQL query is not supported yet: {code}",
# SQLGlot does not propagate tokens yet. See https://github.com/tobymao/sqlglot/issues/3159
start_line=0,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/source_code/linters/test_dbfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_dbfs_queries_failure(query: str):
actual = list(ftf.lint(query))
assert actual == [
Failure(
code='dbfs-query',
code='dbfs-query-unsupported-sql',
message=f'SQL query is not supported yet: {query}',
start_line=0,
start_col=0,
Expand Down