Skip to content

Conversation

@sin
Copy link
Contributor

@sin sin commented Apr 22, 2022

Some of the links are formatted as function_name() or library::function_name() instead of just function_name. This is the convention in the tidyverse's docs.

This change simply removes the brackets and splits the library and function names.

Link to tidyselect::vars_pull() from tidyr:

Before: /link/tidyselect::vars_pull()?package=tidyr
After: /link/vars_pull?package=tidyselect

More info in #81.

Some of the links are formatted as `function_name()` or `library::function_name()` instead of just `function_name`. This is the convention in the tidyverse packages' docs.

This change simply removes the brackets and splits the library and function names.

Link to `tidyselect::vars_pull()` from tidyr:

Before: /link/tidyselect::vars_pull()?package=tidyr
After:  /link/vars_pull?package=tidyselect
Copy link
Contributor

@ztsorojev ztsorojev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🏆
Thank you! I will merge! 🤝

@ztsorojev ztsorojev merged commit 339bc26 into datacamp:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants