-
-
Notifications
You must be signed in to change notification settings - Fork 125
Explicitly set dark mode images to avoid varnish image color inversion #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Explicitly set dark mode images to avoid varnish image color inversion #350
Conversation
…have background, it's less legible with dark text in dark mode
…ng them inverted with dark mode does not impact the episode
…-objects-coloured-by-area.png
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-350 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-12-09 11:56:41 +0000 |
As explained in #349, varnish defaults to inverting all images included in the curriculum for dark mode. This is a problem as most of the material included here relies on the raw 'light-mode' images appearance.
This PR closes #349 by explicitly creating copies of all images that need to be preserved as-is in light-mode by appending
-darkto the image file names (discussed here).Originally I was making a copy of all images, but I found several histograms and/or images that had a transparent background. This caused the black text on black background (in dark-mode) to be unreadable, so I either updated the images to have a complete white background, or left varnish doing its magic to invert the color scheme. The only side effect of this choice is that there's no consistent aesthetics to all graphs, but there were inconsistencies between fonts and style before anyway.
I tried to go through all the content to see if all images and text references still make sense with these figures, but it would be great if you could double-check if I missed something.