-
-
Notifications
You must be signed in to change notification settings - Fork 314
01-short-introduction-to-Python.md: add keypoints #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @bsyouness, I added a couple more specific suggestions for wording changes. Let me know if these look OK. If I don't hear back by Monday, Nov. 5, I'll merge this with my changes incorporated. Thanks! |
|
Hi @wrightaprilm! I don't see the suggestions you mentioned? |
|
Whoops, didn't realize I had to submit the review for them to be visible to you! |
Co-Authored-By: bsyouness <bs.youness@gmail.com>
Co-Authored-By: bsyouness <bs.youness@gmail.com>
|
Thanks for reviewing @wrightaprilm! |
|
OK, I think with changes incorporated, we're OK for merge if you're happy, @maxim-belkin |
|
I'll comment closer to the end of the week. Would that work? If not, you can merge this PR and I will create an issue with my comments (if I don't forget). |
|
PS. If what I suggested works for you -- please request a review from me. |
maxim-belkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my commends above.
Thank you for the PR, @bsyouness!
|
I think we're very close on this. @bsyouness, would you like to resolve the outstanding notes in Maxim's review? Otherwise, we'll probably open it up to further community contributions. Thanks! |
maxim-belkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bsyouness!
Added the highlights of episode 1 at the end of the page.