Skip to content

Conversation

@bsyouness
Copy link
Contributor

Added the highlights of episode 1 at the end of the page.

@wrightaprilm wrightaprilm added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Oct 30, 2018
@wrightaprilm
Copy link
Contributor

Hi @bsyouness, I added a couple more specific suggestions for wording changes. Let me know if these look OK. If I don't hear back by Monday, Nov. 5, I'll merge this with my changes incorporated. Thanks!

@bsyouness
Copy link
Contributor Author

Hi @wrightaprilm! I don't see the suggestions you mentioned?

@wrightaprilm
Copy link
Contributor

Whoops, didn't realize I had to submit the review for them to be visible to you!

wrightaprilm and others added 2 commits October 30, 2018 13:36
Co-Authored-By: bsyouness <bs.youness@gmail.com>
Co-Authored-By: bsyouness <bs.youness@gmail.com>
@bsyouness
Copy link
Contributor Author

Thanks for reviewing @wrightaprilm!

wrightaprilm
wrightaprilm previously approved these changes Oct 31, 2018
@wrightaprilm
Copy link
Contributor

OK, I think with changes incorporated, we're OK for merge if you're happy, @maxim-belkin

@maxim-belkin
Copy link
Contributor

I'll comment closer to the end of the week. Would that work? If not, you can merge this PR and I will create an issue with my comments (if I don't forget).

@maxim-belkin
Copy link
Contributor

PS. If what I suggested works for you -- please request a review from me.

@maxim-belkin maxim-belkin changed the title Added keypoints for episode 1 01-short-introduction-to-Python.md: add keypoints Oct 31, 2018
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my commends above.
Thank you for the PR, @bsyouness!

@wrightaprilm
Copy link
Contributor

I think we're very close on this. @bsyouness, would you like to resolve the outstanding notes in Maxim's review? Otherwise, we'll probably open it up to further community contributions. Thanks!

@wrightaprilm wrightaprilm dismissed their stale review January 28, 2019 16:19

Re-review after changes.

Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bsyouness!

@maxim-belkin maxim-belkin merged commit dc95a25 into datacarpentry:gh-pages Jan 28, 2019
zkamvar pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants