Skip to content

Conversation

@dmitriibugakov
Copy link
Collaborator

@dmitriibugakov dmitriibugakov commented Oct 1, 2024

Close: #8

@dmitriibugakov dmitriibugakov requested a review from alamb October 1, 2024 13:18
@dmitriibugakov
Copy link
Collaborator Author

@alamb How do you feel about it?
Do you think we’re ready to release version 0.1.0?

@alamb
Copy link
Contributor

alamb commented Oct 1, 2024

@alamb How do you feel about it? Do you think we’re ready to release version 0.1.0?

I am not quite sure how this (seemingly magic) github action works, but I do think we should release verion 0.1.0 🚀


release:
needs: [check]
if: "success() && startsWith(github.ref, 'refs/tags/')"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the release only happens on a successful check and when the ref is a tag.

@austin362667
Copy link
Collaborator

Thank you @dmitrybugakov
IMO I think it's ok to do this, I've seen similar CI tricks in release check in https://github.com/pydantic/pydantic-core/blob/e3eff5cb8a6dae8914e3831b00c690d9dee4b740/.github/workflows/ci.yml#L709

@dmitriibugakov dmitriibugakov merged commit 97c2e4c into datafusion-contrib:main Oct 2, 2024
5 checks passed
@dmitriibugakov dmitriibugakov deleted the add-release-action branch October 2, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Release Action to CI Workflow

3 participants