fix(protobuf): use DynamicMessage for MESSAGE-type extension defaults #14900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
abedatahub
force-pushed
the
abe--fix-proto-to-datahub-CUS-5782
branch
from
fede1dd to
00a4702
Compare
Fixed extension registry initialization for MESSAGE-type extensions by using DynamicMessage.getDefaultInstance(FieldDescriptor) instead of FieldDescriptorProto.getDefaultInstanceForType(). The latter would simply get a default instance of a FieldDesriptorProto message, clearly not our intention. Added test coverage for MESSAGE-type extensions using messageF.proto, which exercises the case where extension values are message types rather than primitives or enums. Verified that this fixes the customer issue by running the datahub-protobuf CLI against the files provided in https://acrylsupport.zendesk.com/agent/tickets/4845 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
abedatahub
force-pushed
the
abe--fix-proto-to-datahub-CUS-5782
branch
from
00a4702 to
da24f4f
Compare
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
david-leifker
approved these changes
Oct 1, 2025
datahub-cyborg
bot
added
merge-pending-ci
yoonhyejin
pushed a commit
that referenced
this pull request
Oct 9, 2025
…#14900) Co-authored-by: Claude <noreply@anthropic.com>
alplatonov
pushed a commit
to alplatonov/datahub
that referenced
this pull request
Oct 13, 2025
…datahub-project#14900) Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed extension registry initialization for MESSAGE-type extensions by using
DynamicMessage.getDefaultInstance(FieldDescriptor) instead of
FieldDescriptorProto.getDefaultInstanceForType(). The latter would simply
get a default instance of a FieldDesriptorProto message, clearly not our
intention.
Added test coverage for MESSAGE-type extensions using messageF.proto, which
exercises the case where extension values are message types rather than
primitives or enums.
Verified that this fixes the customer issue by running the datahub-protobuf
CLI against the files provided in https://acrylsupport.zendesk.com/agent/tickets/4845
🤖 Generated with Claude Code