fix(ingest): Handle empty column names in SQL parsing column lineage #15013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
treff7es
reviewed
Oct 16, 2025
| aggregator.add_known_query_lineage(known_query_lineage) | ||
|
|
||
| # This should not raise an error even with empty string columns | ||
| mcps = list(aggregator.gen_metadata()) |
Contributor
There was a problem hiding this comment.
I think it is better to use golden files as it is easier to understand what is going on.
Check out the test above which uses it ->
mcpws = [mcp for mcp in aggregator.gen_metadata()]
lineage_mcpws = [mcpw for mcpw in mcpws if mcpw.aspectName == "upstreamLineage"]
out_path = tmp_path / "mcpw.json"
write_metadata_file(out_path, lineage_mcpws)
mce_helpers.check_golden_file(
pytestconfig,
out_path,
pytestconfig.rootpath
/ "tests/unit/sql_parsing/aggregator_goldens/test_diamond_problem_golden.json",
)
Contributor
Author
There was a problem hiding this comment.
Thank you for the comment. Revised.
datahub-cyborg
bot
added
pending-submitter-response
kyungsoo-datahub
force-pushed
the
ks--fix-empty-column-failure
branch
from
87e9c03 to
834152b
Compare
datahub-cyborg
bot
added
pending-submitter-response
Bundle ReportChanges will increase total bundle size by 19.29kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
skrydal
reviewed
Oct 20, 2025
metadata-ingestion/src/datahub/sql_parsing/sql_parsing_aggregator.py
Outdated
Show resolved
Hide resolved
skrydal
reviewed
Oct 20, 2025
Collaborator
|
Very nice and thoughtful change @kyungsoo-datahub , just shared couple of minor comments. Thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
needs-review
skrydal
approved these changes
Oct 21, 2025
Collaborator
skrydal
left a comment
skrydal
left a comment
There was a problem hiding this comment.
Awesome work, I am approving now. Maybe we should merge it now, if there are more cases, we can simply create a new PR. Up to you.
datahub-cyborg
bot
removed
the
needs-review
datahub-cyborg
bot
added
the
merge-pending-ci
Change - Skip column lineage entries with empty column names to prevent errors during lineage generation - Skip lineage entries with empty or whitespace-only downstream column names before processing - Add comprehensive unit test to verify the fix handles various edge cases Problem A query metadata can sometimes include empty string column names in the column lineage. This causes errors when constructing SchemaFieldUrn objects, breaking the entire lineage generation process. Fix - Only process column lineage when upstream_ref.column is not empty Testing - Added unit test with three scenarios covering edge cases
Clarify use of KnownQueryLineageInfo over ObservedQuery to avoid mocking _run_sql_parser() for testing empty column names from external systems.
kyungsoo-datahub
force-pushed
the
ks--fix-empty-column-failure
branch
from
31cc611 to
78d0456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Problem
A query metadata can sometimes include empty string column names in the column lineage. This causes errors when constructing SchemaFieldUrn objects, breaking the entire lineage generation process.
Fix
Testing