Skip to content

Conversation

@adamnellis
Copy link
Contributor

[sc-132159]

Added Python 3.8, 3.9, 3.10, 3.11


The nltk and sumy libraries needed bumping for the newer versions of Python.

  • I only bumped them for newer versions of Python that this plugin did not support before now
  • According to their docs we could bump them for older Pythons as well, but I left them to be 100% sure of not changing anything for users who are on older versions of Python
    • latest nltk says it supports Python 3.7
    • latest sumy says it supports Python 3.6

Tested this by:

@adamnellis adamnellis added the enhancement New feature or request label Apr 26, 2023
@adamnellis adamnellis requested a review from AgatheG April 26, 2023 16:24
@adamnellis adamnellis self-assigned this Apr 26, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #132159: [text-summarization][AIML] necessary update.

@AgatheG AgatheG added this to the 1.4.0 milestone Apr 27, 2023
Copy link
Contributor

@AgatheG AgatheG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from 2.7 to 3.11, no issues ✅

@AgatheG AgatheG merged commit 168e20f into master Apr 27, 2023
@AgatheG AgatheG deleted the chore/update-python-versions branch April 27, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants