Adds proxy server to minio / aws s3 storage #962
Conversation
There was a problem hiding this comment.
@MaxFBurg 🚀 Awesome job in finding a solution for proxy mode with S3! 🚀
There are a few minor items that were not considered here but they are mainly related to tests and code coverage. Offered suggestions to make it easy to get this in but other than that this looks great!
… test Co-authored-by: Raphael Guzman <38401847+guzman-raphael@users.noreply.github.com>
Co-authored-by: Raphael Guzman <38401847+guzman-raphael@users.noreply.github.com>
|
@guzman-raphael Thank you very much for your comments and the very nice feedback and helpful explanations, I highly appreciate that! I committed all your suggestions - just let me know if you need anything else. |
There was a problem hiding this comment.
@MaxFBurg Not a problem! 🤝
Almost there; just need to fix a small typo that I made in my previous suggestion. 😅
Co-authored-by: Raphael Guzman <38401847+guzman-raphael@users.noreply.github.com>
Co-authored-by: Raphael Guzman <38401847+guzman-raphael@users.noreply.github.com>
There was a problem hiding this comment.
@MaxFBurg Thanks for fixing these updates and ...
🎉 Congrats on your first contribution! 🎉
|
Thank you very much @guzman-raphael ! |
This PR adds the possibility to configure a proxy server for the mini / aws s3 storage. The PR resolves #961 .