Kebab case #110
Merged
Kebab case #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-schneider
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
lgtm 👍 builds successfully with the scripsi changes in https://github.com/riptano/scripsi/pull/31
You're probably already planning on this, but at some point as part of the Unified Site project, you'll need to change the adoc source file names to kebab case as well. Though, it's probably worth holding off on that until we figure out a plan to handle bulk re-directs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR to kebab-case cdcCassandra.
Builds to coppi with no errors:
https://coppi.aws.dsinternal.org/en/kebab-case/docs/2.2.2/
Related to https://github.com/riptano/scripsi/pull/31