Skip to content

Conversation

@aymkhalil
Copy link
Contributor

This patch:

  • Adds CLI args to configure Pulsar client (via the agent)
  • Add Pulsar Importer happy case tests
  • Supports multiple PK keys

@aymkhalil aymkhalil requested a review from eolivelli February 23, 2023 01:28
Copy link
Collaborator

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I left a very minor comment.

package com.datastax.oss.cdc.backfill;

import com.datastax.oss.cdc.backfill.util.TableUtils;
import com.amazonaws.services.kms.model.UnsupportedOperationException;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look like the right package

@aymkhalil aymkhalil merged commit c520f27 into master Feb 23, 2023
@cbornet cbornet deleted the pulsar-importer branch February 24, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants