Bootstrap CDC backfill CLI e2e tests #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
Feb 28, 2023
| // given | ||
| Config connectorConfig = createConnectorConfigs("sample-001.csv"); | ||
| connector.configure(connectorConfig, true, true); | ||
| connector.init(); |
There was a problem hiding this comment.
why are we removing this ?
There was a problem hiding this comment.
in DSBulk, the init() is responsible for calculating the directory/file structure of the exported table so the init should happen lazily. I moved it to when the actual import is called - will add unit tests for it. Alternatively I can keep it here and just inject a factory class into the importer.
aymkhalil
force-pushed
the
e2e-tests
branch
2 times, most recently
from
d9eb832 to
67349b4
Compare
aymkhalil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is setup the first backfill e2e test. What's remaining: