Limit the number of inflight pulsar mutations #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Mar 3, 2023
| // TODO: Disable the e2e latency metric if the records are emitted from cdc back-filling CLI | ||
| final long tsMicro = Instant.now().toEpochMilli() * 1000; | ||
| futures.add(mutationSender.sendMutationAsync(createMutation(pkValues.toArray(), this.exportedTable.getCassandraTable(), tsMicro))); | ||
| sendMutationAsync(createMutation(pkValues.toArray(), this.exportedTable.getCassandraTable(), tsMicro)); |
There was a problem hiding this comment.
we are not handling failures
In case of failures we must report the error and retry
One proposal:
- keep accumulating a list of Futures
- every 1000 futures, wait for the results (then clear the list), fail the procedure in case there is one failure
There was a problem hiding this comment.
Error handling is implemented here: https://github.com/datastax/cdc-apache-cassandra/pull/118/files#diff-19495dbde526d4197418c17b952a3d8eb743402e9e8c7c01aafb05d503e28610R189
It logs, and the futures keep progressing. In the end, it reports the number of succeeded, failed, skipped.
@eolivelli does that address your comment at least for V0?
|
The latest patch:
@eolivelli PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of inflight pulsar mutations to 1000 (hard coded for now) inspired by how the agent doesn't (independent from the blocking send capabilities in the pulsar client)