Skip to content

Parse extra backfill configs from client.conf and CLI #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2023
Merged

Parse extra backfill configs from client.conf and CLI #121

merged 4 commits into from
Mar 16, 2023

Conversation

@aymkhalil
Copy link
Contributor

@aymkhalil aymkhalil commented Mar 16, 2023 •
edited
Loading

This patch:

  • Read pulsar client related configs (broker url, tls, etc) from the client conf
  • Adds the exhaustive list of options available in the backfill CLI to the pulsar admin extension variant
  • Handle list array option --export-dsbulk-option
  • Improves error messages returned from picocli to pulsar admin

@aymkhalil aymkhalil requested a review from eolivelli March 16, 2023 00:47
@aymkhalil aymkhalil marked this pull request as ready for review March 16, 2023 00:47
@aymkhalil aymkhalil merged commit 82a5c9f into master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aymkhalil