Skip to content

Conversation

@aymkhalil
Copy link
Contributor

@aymkhalil aymkhalil commented Mar 21, 2023

The patch updates the Cassandra CDC backfill CLI to use the Pulsar Admin CLI Extension for e2e testing. The motivation:

  1. The "extension" is the recommend way to run backfilling.
  2. It already exercise the code path that was previously tested if someone where to run the jar directly with the exception of a thin wrapper for the CLI entry point.

If necessary, we could enable tests on both the JAR and the NAR artifacts but this seems like an overkill for the time being.

Update: I'll fall back to testing with the JAR when CLI ext is not enabled.

@aymkhalil aymkhalil marked this pull request as ready for review March 22, 2023 21:55
@aymkhalil aymkhalil merged commit 5ac72a7 into master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants