Handle collections embedded into UDT (where length encoded into 4byte)#126
Closed
mishail wants to merge 1 commit intoapache:1.xfrom
Closed
Handle collections embedded into UDT (where length encoded into 4byte)#126mishail wants to merge 1 commit intoapache:1.xfrom
mishail wants to merge 1 commit intoapache:1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
This check will break when there are more than 2^16 elements in the collection.
I think we need to start passing the protocol version to serialize/deserialize methods. When decoding UDTs, we can use max(3, protocol_version) to decode subfields.
I need to start working on adding 2.1 support in any case, so maybe this is the best place to start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/CASSANDRA-7267