Skip to content

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented Jun 8, 2022

Problem:
Uploading cdx file caused an error - no element found.

Solution:
There were 2 mistakes:
1. the redirect from the input file to the patched output
files had been deleted. Added back redirection.
2. The embedded python refenced component.find() when component
had not been yet created. Moved the component definition
to earlier in the python code.

Signed-off-by: Paul Hewlett phewlett76@gmail.com

Problem:
Uploading cdx file caused an error - no element found.

Solution:
There were 2 mistakes:
    1. the redirect from the input file to the patched output
       files had been deleted. Added back redirection.
    2. The embedded python refenced component.find() when component
       had not been yet created. Moved the component definition
       to earlier in the python code.

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
Copy link
Contributor

@wp0pw wp0pw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eccles eccles merged commit 9e3dcaf into main Jun 8, 2022
@eccles eccles deleted the dev/eccles/fix-no-element-found branch June 8, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants