Skip to content

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented May 28, 2021

Problem:
Access to this repo must be available to any user on github.

Solution:
Describe in README the acceptable workflow using the 'fork' option in
the github UI.

Signed-off-by: eccles phewlett76@gmail.com

@ghost ghost requested review from a user, j-hartley and leflambeur May 28, 2021 14:05
@ghost ghost requested review from JAG-UK and robinbryce May 28, 2021 14:32
Copy link
Contributor

@leflambeur leflambeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes - we need to Americanize things like synchronizing instead of synchronising

Worth doing a re-check of this and archivist-python to make sure it matches the docs style guide - link for ref. https://jitsuin-inc.github.io/rkvst-docs/contributing/formatting-content/style-guide/#grammar

Once you have reviewed it and updated those please squish the commits and I will approve it and merge

Problem:
Access to this repo must be available to any user on github.

Solution:
Describe in README the acceptable workflow using the 'fork' option in
the github UI.

Signed-off-by: eccles <phewlett76@gmail.com>
@leflambeur
Copy link
Contributor

LGTM and all checks passed, will merge now

@leflambeur leflambeur merged commit 6727227 into datatrails:main Jun 1, 2021
@eccles eccles deleted the dev/eccles/define-correct-workflow branch June 1, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants