Skip to content

fix off by 1 error in inclusion proof #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix off by 1 error in inclusion proof #19

merged 1 commit into from
Jan 20, 2025

Conversation

@honourfish
Copy link
Contributor

@honourfish honourfish commented Jan 20, 2025

Overview

  • veracity testing shows we had an off by one

Testing

tested prod assetsv2 event inclusion verification using veracity:

=== RUN   TestVerifyEventsSuite
    /home/jgough/workspace/veracity/tests/verifyincluded/suite.go:234: warning: no tests to run
--- PASS: TestVerifyEventsSuite (0.00s)
PASS
ok      github.com/datatrails/veracity/tests/verifyincluded     0.008s

re: AB#10216

@honourfish honourfish requested review from henry739 and wp0pw January 20, 2025 11:08
@honourfish honourfish enabled auto-merge (squash) January 20, 2025 12:05
@honourfish honourfish merged commit 5f0be1c into main Jan 20, 2025
1 check passed
@honourfish honourfish deleted the dev/jgough/10216-inclusion-off-by-one branch January 20, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henry739 henry739 Awaiting requested review from henry739

1 more reviewer

@wp0pw wp0pw wp0pw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@honourfish @wp0pw