Skip to content

Serialize the eventv1 from the eventsv1 API response #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

Serialize the eventv1 from the eventsv1 API response #2

merged 2 commits into from
Dec 12, 2024

Conversation

@honourfish
Copy link
Contributor

Overview

  • use customer accessible fields for the serialization of eventsv1 events
  • Add a FromJson method that takes a json response from the eventsv1 API and gets the serialized event bytes.

Testing

  • updated unit tests

re: AB#10260

@honourfish honourfish merged commit 13e1edb into main Dec 12, 2024
1 check passed
@honourfish honourfish deleted the dev/jgough/10260-serialize-api-resp branch December 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wp0pw wp0pw wp0pw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@honourfish @wp0pw