Skip to content

Conversation

@cbenz
Copy link
Collaborator

@cbenz cbenz commented Aug 16, 2019

Found that while working on a theme: error stack trace was not displayed.

I reproduced the way plugin errors are displayed

console.warn('WARNING: Failed to load configured plugins', plugins, e)

Before:

Loading configured theme...                                                                                                                   
ckan-ng-theme-xxx                                                                                                                           
WARNING: Failed to load theme -- ckan-ng-theme-xxx                                                                                          
Loading configured plugins...                                                                                                                 
Listening on :4000                                                                                                                            

After:

Loading configured theme...                                                                                                                   
ckan-ng-theme-xxx                                                                                                                          
Loading configured plugins...                                                                                                                 
Listening on :4000                                                                                                                            
(node:8540) UnhandledPromiseRejectionWarning: ReferenceError: utils is not defined                                                            
    at app.get (/home/cbenz/Dev/datopian/frontend-v2/themes/ckan-ng-theme-xxx/index.js:54:22)                                               
    at process._tickCallback (internal/process/next_tick.js:68:7)                                                                             
(node:8540) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async functio
n without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)                                     
(node:8540) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled 
will terminate the Node.js process with a non-zero exit code.                                                                                 

Copy link
Member

@anuveyatsu anuveyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍 thanks!

@anuveyatsu anuveyatsu merged commit 2e054a3 into master Aug 19, 2019
@anuveyatsu anuveyatsu deleted the display-theme-errors branch August 19, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants