Skip to content

Conversation

@sagargg-zz
Copy link
Contributor

  • svg icons added
  • hardcoded url path changed

Copy link
Member

@anuveyatsu anuveyatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagargg this isn't what we want to do. We don't want to hardcode these groups/collections but get them dynamically from the API and show them based on the tag "featured". If we have more than 4 "featured" groups, we want to show random 4 of them.

@sagargg-zz
Copy link
Contributor Author

@anuveyatsu I'm not sure but as you said overriding the controlles isn't right way to do that. So, ATM i just added hardcoded. I think we should find out other way to extend the controller rather than overriding.

@anuveyatsu
Copy link
Member

@sagargg I think we should close this PR and create a new one. But first we need to fix #86

@sagargg-zz
Copy link
Contributor Author

Closed ATM

@sagargg-zz sagargg-zz closed this Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants