[ckan_pages] plugin home controller override converted as middleware controller #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sagargg-zz
commented
Sep 20, 2019
sagargg-zz
commented
- Fixed Montreal not showing recent data issues
anuveyatsu
reviewed
Sep 20, 2019
Member
anuveyatsu
left a comment
anuveyatsu
left a comment
There was a problem hiding this comment.
I'll fix my small comments as we want this to be merged asap. @sagargg please review my comments.
plugins/ckan_pages/index.js
Outdated
| title: 'Home', | ||
| posts | ||
| }) | ||
| res.locals.post= posts |
Member
There was a problem hiding this comment.
@sagargg please, either be more careful with the spaced or use a linter. You can see there is no space before equal sign.
plugins/ckan_pages/index.js
Outdated
| const Model = new cms.CmsModel() | ||
|
|
||
| app.get('/', async (req, res) => { | ||
| app.get('/', async (req, res,next) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.