Skip to content
This repository was archived by the owner on Jan 7, 2022. It is now read-only.

Catch LevelDB OpenErrors#28

Merged
joehand merged 3 commits intomasterfrom
level-open-errors
Nov 3, 2016
Merged

Catch LevelDB OpenErrors#28
joehand merged 3 commits intomasterfrom
level-open-errors

Conversation

@juliangruber
Copy link
Copy Markdown
Collaborator

This is fix part one for dat-ecosystem/dat#561, next we just need to print a nice error message if /^OpenError/.test(err.message).

@yoshuawuyts
Copy link
Copy Markdown
Collaborator

It might perhaps be useful to use
https://github.com/dominictarr/explain-error for our error forwarding ✨

On Tue, Nov 1, 2016, 7:45 PM Julian Gruber notifications@github.com wrote:

This is fix part one for dat-ecosystem/dat#561
dat-ecosystem/dat#561, next we just need to

print a nice error message if /^OpenError/.test(err.message).

You can view, comment on, or merge this pull request online at:

https://github.com/joehand/dat-js/pull/28
Commit Summary

  • forward db open errors to the dat.open() callback
  • catch leveldb open errors
  • add passing test for leveldb open errors

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/joehand/dat-js/pull/28, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlelruQHWbmlluMipFlq4xRaovY1ifks5q54i-gaJpZM4Kmb8g
.

@joehand joehand merged commit b4c0e28 into master Nov 3, 2016
@joehand joehand deleted the level-open-errors branch November 3, 2016 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants