Improve usability when try to link a dat url#454
Merged
max-mapper merged 2 commits intodat-ecosystem:masterfrom Mar 1, 2016
Merged
Improve usability when try to link a dat url#454max-mapper merged 2 commits intodat-ecosystem:masterfrom
max-mapper merged 2 commits intodat-ecosystem:masterfrom
Conversation
Collaborator
|
good idea! do you wanna take a stab at writing a basic test for this? this one is a good template https://github.com/maxogden/dat/blob/master/tests/link.js#L27-L37 also the travis failure on node 5.x should be fixed if you rebase to master (i believe @mafintosh fixed that earlier today) |
Contributor
Author
|
tests added. PR test runs actually do try to merge to master, so got the master fixes there alright. ;) |
Collaborator
|
nice! |
max-mapper
added a commit
that referenced
this pull request
Mar 1, 2016
Improve usability when try to link a dat url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.