GitHub Actions#85
Conversation
RangerMauve
left a comment
There was a problem hiding this comment.
This look super useful. Thank you for putting in the effort. 😁
|
Actually, is it possible to run this on tags and to upload the bundle to the release artifacts? I've only ever used that functionality with electron-builder so I'm not sure how it works for regular node modules. 😅 |
Aha, I seem to have found this: https://github.com/softprops/action-gh-release
I haven't committed support for it just yet, but it looks like it'd be as simple as So, in any case, it should only formally attach artifacts to Release-tagged commits; but do you want me to have it build stuff for pushes and PRs anyway, for general CI purposes? It looks like it will require some sort of token, once accepted:
|
|
Hmm, actually, upon further inspection:
It looks like, to leverage that Action to attach files to Releases automatically, you would also have to entrust it with the creation of Releases, which would probably entail having a separate I will have to do a bit more research into the options for automatically attaching build artifacts to Releases. (Though, as currently drafted, this PR would enable "simply" downloading the Artifact associated with a commit and attaching it to its associated Release manually.) |
|
@JamesTheAwesomeDude I can supply the GH token for this, sure.
Your call on what you think would be useful for folks. 😁
Can it detect new tags to create releases? That's what electron-builder does in Agregore Also, if you're not interested in messing around with the release stuff I'm okay with leaving it as a TODO and doing the PR based build artifact thing in the meantime. There's no pressure either way of course. 😁 |
RangerMauve
left a comment
There was a problem hiding this comment.
I think this looks good as is. 😁 Any fancier stuff can be added in later PRs.
Thank you so much for working on this.
This PR calls GitHub's free CI service whenever a push or a pull request is made. It additionally makes build artifacts available to download and take for a spin without ever having to set up a development environment on one's local machine.
Does it look appropriate?