-
-
Notifications
You must be signed in to change notification settings - Fork 4
📚 Fix typos #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 Fix typos #141
Conversation
|
Damn. It's hard to know what to do with a PR like this. On the one hand I appreciate the correction of the typos and I welcome contributions; but on the other hand the profile looks super bot-like and if I try and visit the profile's website I get this: It seems really bizarre that someone would block like that. |
| ############################################################################## | ||
| @mark.parametrize("string", ("", "1")) | ||
| def test_tag_langth(string: str) -> None: | ||
| """We should be able to get the len of a tag.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no, len is correct here; it's testing if we can get the len of the tag -- as in it should be possible to call the function len on the tag.
davep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last check to see if this is a bot or a human.
Definitely a human, will come back to you on this later. |
Found via `codespell -L wee` and `typos --hidden --format brief`
Thanks for letting me know. I've unintentionally gave that impression several times for some, as I frequently hop through various GitHub repositories each day, submitting minor pull requests, such as fixing typos. Exploring GitHub repositories has become a daily ritual reminiscent of the early days of browsing different FLOSS projects on the now-defunct freshmeat.net.
Could you check if the issue still persists? I suspect that I may have inadvertently auto blocked some ASNs many moons ago, which could be the cause of this problem. |
davep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You've also reminded me that I should add codespell as a development dependency, make it a pre-commit check and also add it to CI too.
I've unintentionally gave that impression several times for some, as I frequently hop through various GitHub repositories each day, submitting minor pull requests, such as fixing typos.
Sounds good; and thanks for taking the check in the spirit it was intended (I didn't want to dismiss on sight alone).
Exploring GitHub repositories has become a daily ritual reminiscent of the early days of browsing different FLOSS projects on the now-defunct freshmeat.net.
Freshmeat! There's a name I've not seen in a long time! Back in the days when I still had dial-up Internet access only I used to have a tool ran on my local GNU/Linux server that, on connection to my ISP, would grab the latest info from them and then email a summary to me.
Fun times.
|
🥳 🥳 🥳 🥳 🥳 |
|
PS: I forgot to say... yes, the site is visible now. |

Found via
codespell -L weeandtypos --hidden --format brief