Skip to content

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Apr 5, 2025

Found via codespell -L wee and typos --hidden --format brief

@davep
Copy link
Owner

davep commented Apr 5, 2025

Damn. It's hard to know what to do with a PR like this. On the one hand I appreciate the correction of the typos and I welcome contributions; but on the other hand the profile looks super bot-like and if I try and visit the profile's website I get this:

Screenshot 2025-04-05 at 22 21 33

It seems really bizarre that someone would block like that.

##############################################################################
@mark.parametrize("string", ("", "1"))
def test_tag_langth(string: str) -> None:
"""We should be able to get the len of a tag."""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no, len is correct here; it's testing if we can get the len of the tag -- as in it should be possible to call the function len on the tag.

Copy link
Owner

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last check to see if this is a bot or a human.

@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 7, 2025

Last check to see if this is a bot or a human.

Definitely a human, will come back to you on this later.

Found via `codespell -L wee` and `typos --hidden --format brief`
@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 7, 2025

Damn. It's hard to know what to do with a PR like this. On the one hand I appreciate the correction of the typos and I welcome contributions; but on the other hand the profile looks super bot-like and if I try and visit the profile's website I get this:

Thanks for letting me know.

I've unintentionally gave that impression several times for some, as I frequently hop through various GitHub repositories each day, submitting minor pull requests, such as fixing typos. Exploring GitHub repositories has become a daily ritual reminiscent of the early days of browsing different FLOSS projects on the now-defunct freshmeat.net.

It seems really bizarre that someone would block like that.

Could you check if the issue still persists? I suspect that I may have inadvertently auto blocked some ASNs many moons ago, which could be the cause of this problem.

@kianmeng kianmeng requested a review from davep April 7, 2025 12:19
Copy link
Owner

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You've also reminded me that I should add codespell as a development dependency, make it a pre-commit check and also add it to CI too.

I've unintentionally gave that impression several times for some, as I frequently hop through various GitHub repositories each day, submitting minor pull requests, such as fixing typos.

Sounds good; and thanks for taking the check in the spirit it was intended (I didn't want to dismiss on sight alone).

Exploring GitHub repositories has become a daily ritual reminiscent of the early days of browsing different FLOSS projects on the now-defunct freshmeat.net.

Freshmeat! There's a name I've not seen in a long time! Back in the days when I still had dial-up Internet access only I used to have a tool ran on my local GNU/Linux server that, on connection to my ISP, would grab the latest info from them and then email a summary to me.

Fun times.

@davep davep mentioned this pull request Apr 7, 2025
@davep davep closed this pull request by merging all changes into davep:main in 9ddbc6d Apr 7, 2025
@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 7, 2025

🥳 🥳 🥳 🥳 🥳

@davep
Copy link
Owner

davep commented Apr 7, 2025

PS: I forgot to say... yes, the site is visible now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants