Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/InputRange/InputRange.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ const internals = new WeakMap();
* @const {Object.<string, number>}
*/
const KeyCode = {
DOWN_ARROW: 40,
LEFT_ARROW: 37,
RIGHT_ARROW: 39,
UP_ARROW: 38,
};

/**
Expand Down Expand Up @@ -393,10 +395,14 @@ export default class InputRange extends React.Component {

switch (event.keyCode) {
case KeyCode.LEFT_ARROW:
case KeyCode.DOWN_ARROW:
event.preventDefault();
this.decrementValue(key);
break;

case KeyCode.RIGHT_ARROW:
case KeyCode.UP_ARROW:
event.preventDefault();
this.incrementValue(key);
break;

Expand Down
78 changes: 78 additions & 0 deletions test/InputRange.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ describe('InputRange', () => {
slider = inputRange.refs.sliderMax;
event = {
keyCode: 37,
preventDefault: jasmine.createSpy('preventDefault'),
};
});

Expand All @@ -228,6 +229,44 @@ describe('InputRange', () => {
expect(inputRange.decrementValue).toHaveBeenCalledWith('max');
});

it('should call event.preventDefault()', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(event.preventDefault).toHaveBeenCalledWith();
});

it('should not decrement value if disabled', () => {
inputRange = renderComponent(<InputRange disabled={true} defaultValue={10} onChange={onChange}/>);
spyOn(inputRange, 'decrementValue');
inputRange.handleSliderKeyDown(event, slider);

expect(inputRange.decrementValue).not.toHaveBeenCalled();
});
});

describe('when pressing down arrow key', () => {
beforeEach(() => {
spyOn(inputRange, 'decrementValue');

slider = inputRange.refs.sliderMax;
event = {
keyCode: 40,
preventDefault: jasmine.createSpy('preventDefault'),
};
});

it('should decrement value', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(inputRange.decrementValue).toHaveBeenCalledWith('max');
});

it('should call event.preventDefault()', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(event.preventDefault).toHaveBeenCalledWith();
});

it('should not decrement value if disabled', () => {
inputRange = renderComponent(<InputRange disabled={true} defaultValue={10} onChange={onChange}/>);
spyOn(inputRange, 'decrementValue');
Expand All @@ -244,6 +283,7 @@ describe('InputRange', () => {
slider = inputRange.refs.sliderMax;
event = {
keyCode: 39,
preventDefault: jasmine.createSpy('preventDefault'),
};
});

Expand All @@ -253,6 +293,44 @@ describe('InputRange', () => {
expect(inputRange.incrementValue).toHaveBeenCalledWith('max');
});

it('should call event.preventDefault()', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(event.preventDefault).toHaveBeenCalledWith();
});

it('should not increment value if disabled', () => {
inputRange = renderComponent(<InputRange disabled={true} defaultValue={10} onChange={onChange}/>);
spyOn(inputRange, 'incrementValue');
inputRange.handleSliderKeyDown(event, slider);

expect(inputRange.incrementValue).not.toHaveBeenCalled();
});
});

describe('when pressing up arrow key', () => {
beforeEach(() => {
spyOn(inputRange, 'incrementValue');

slider = inputRange.refs.sliderMax;
event = {
keyCode: 38,
preventDefault: jasmine.createSpy('preventDefault'),
};
});

it('should increment value', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(inputRange.incrementValue).toHaveBeenCalledWith('max');
});

it('should call event.preventDefault()', () => {
inputRange.handleSliderKeyDown(event, slider);

expect(event.preventDefault).toHaveBeenCalledWith();
});

it('should not increment value if disabled', () => {
inputRange = renderComponent(<InputRange disabled={true} defaultValue={10} onChange={onChange}/>);
spyOn(inputRange, 'incrementValue');
Expand Down