Skip to content

Conversation

@Stranger6667
Copy link
Contributor

@Stranger6667 Stranger6667 commented Jul 6, 2025

Fixes #490

I see it is an ad-hoc fix to illustrate the issue. I hope that in the end we can arrive at a more fundamental fix + add some more test cases, as it looks quite fragile right now (all the string passing part)

Checklist

❤️ Thank you

@Stranger6667 Stranger6667 force-pushed the dd/nullable-named-args branch from 15431c2 to 5f2bd9c Compare July 6, 2025 11:50
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
@Stranger6667 Stranger6667 force-pushed the dd/nullable-named-args branch from 5f2bd9c to d28d04a Compare July 6, 2025 11:52
@coveralls
Copy link

coveralls commented Jul 6, 2025

Pull Request Test Coverage Report for Build 16098719362

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 22.342%

Totals Coverage Status
Change from base Build 16087646043: 0.02%
Covered Lines: 870
Relevant Lines: 3894

💛 - Coveralls

@Xenira
Copy link
Collaborator

Xenira commented Jul 6, 2025

Thank you. Yes, that string part certainly needs improvement.

Ill release this as soon as possible, as this is something fundamental going wrong here.

@Xenira Xenira added bug Something isn't working regression Something has stopped working labels Jul 6, 2025
@Xenira
Copy link
Collaborator

Xenira commented Jul 6, 2025

@Stranger6667 the linked issue seems to be unrelated. Did you mean #490?

@Stranger6667
Copy link
Contributor Author

Oh, I copy-pasted it from the template and forgot to update )

@Stranger6667
Copy link
Contributor Author

Yes, it is #490

@Xenira Xenira merged commit 501f714 into davidcole1340:master Jul 6, 2025
55 checks passed
@Stranger6667 Stranger6667 deleted the dd/nullable-named-args branch July 6, 2025 12:09
@Xenira
Copy link
Collaborator

Xenira commented Jul 6, 2025

@Stranger6667 just released the fix. Thank you!

@Stranger6667
Copy link
Contributor Author

@Xenira Thank you so much!

I had some thoughts about the defaults and will open another issue later on.

For example, I was wondering if it is feasible to support integer literal suffixes in defaults, such as 42_usize. Right now, it is passed as a literal to the PHP side as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working regression Something has stopped working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defaults are not passed correctly to calls with named arguments

3 participants