feat: support multiple solo filters #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidguttman
force-pushed
the
allow-multi-solo
branch
8 times, most recently
from
bf920c8 to
dcdb0e4
Compare
Enable multiple solo filters to be active simultaneously across dimensions
and values. Previously only one solo filter could be active at a time.
Users can now:
- Solo multiple values within a dimension (e.g., USA + Canada in Country)
- Solo across multiple dimensions (e.g., Country: USA + Status: Active)
- Toggle filters on/off by clicking
Filter logic:
- Multiple values within a dimension are OR'd (USA OR Canada)
- Multiple dimensions are AND'd ((Country: USA OR Canada) AND Status: Active)
Implementation:
- Store solo state as {dimension: {serializedKey: true}} structure
- Toggle behavior: clicking active value removes it, inactive adds it
- Extract filtering logic into createSoloFilter helper
- Add safeParseSoloPayload for safe JSON parsing in dropdown
- Separate addSoloValue/removeSoloValue helper methods
- Use setState callbacks instead of setTimeout
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
davidguttman
force-pushed
the
allow-multi-solo
branch
from
dcdb0e4 to
3871b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.