Skip to content

fix: added missing icons to the types #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 1, 2023
Merged

fix: added missing icons to the types #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
659b991
fix: added missing icon to the types #1573
mfranzke Jul 31, 2023
c157482
fix: added missing icon types
mfranzke Jul 31, 2023
c1988ac
docs: added relevant comment
mfranzke Jul 31, 2023
43b6842
Update iconset.array.ts
mfranzke Jul 31, 2023
9e25115
Update iconset.array.ts
mfranzke Jul 31, 2023
6604e2b
Update iconset.array.ts
mfranzke Jul 31, 2023
eab7aa7
Update iconset.array.ts
mfranzke Jul 31, 2023
fc68d92
Update iconset.array.ts
mfranzke Jul 31, 2023
20187bb
Merge branch 'main' into 1573-missing-icons-to-the-types
mfranzke Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/db-ui-elements-stencil/src/components/db-icon/iconset.array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ export const iconsetAction: string[] = [
'image',
'info',
'intercity-train',
'steppless-entry',
'ticket-subscription',
'walking-fast',
'key',
'legal',
'lightbulb',
Expand Down Expand Up @@ -240,6 +243,7 @@ export const iconsetSeat: string[] = [
'aisle-not-available',
'bed',
'childrens-compartment',
'couchette',
'elderly',
'handicapped',
'parent-child-compartment',
Expand Down Expand Up @@ -274,11 +278,43 @@ export const iconsetTicket: string[] = [
];

export const iconsetTransportation: string[] = [
'airplane',
'bicycle',
'bicycle-trailer',
// 'bikesharing',
// 'bus-local',
// 'bus-long-distance',
'call-a-bike',
'car',
'car-sequence',
'carsharing',
'electric-locomotive',
'electric-scooter',
'ev-car',
'ferry',
'handcart',
'ice',
'ice-side-view',
'local-bus',
'local-train',
'long-distance-bus',
'rail-and-fly',
'railroad-car',
's-bahn',
'scooter',
// 'ship',
'speedboat',
'sprinter',
'subway',
'taxi',
'train-and-car',
// 'train-ec',
// 'train-ic',
// 'train-ice',
// 'train-rb',
// 'train-re',
'tram',
// 'underground',
'walking'
];

Expand Down
2 changes: 2 additions & 0 deletions ...db-ui-elements-stencil/src/components/db-icon/stories/db-icon.intro.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ The icon attribute is to select the icon. To see all Icons visit <a href="https:

The variant attribute specifies the size and style of an icon.

Please be aware that our icons aren't available in all variants (size and type) that we provide for configuration. In case you're missing an icon especially within any size bigger than `20`, please configure a lower size and set the icon-font-size via CSS Custom Property `--icon-font-size-before` on the `db-icon` element.

<Canvas>
<db-icon icon="account" variant="20-outline"></db-icon>
<db-icon icon="account" variant="24-outline"></db-icon>
Expand Down
3 changes: 3 additions & 0 deletions showcase/playground-showcase/src/grapesjs/icons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ export const iconset: string[] = [
'filter',
'generic-card',
'giftcard',
'steppless-entry',
'ticket-subscription',
'walking-fast',
'heart',
'heart-on',
'help',
Expand Down