refactor: not installing plugins for husky npx #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/refactor-husky-npx |
nmerget
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we shouldn't expect
npxto install the plugins as they should already be installed viapackage.jsonentries. Elsewhere we wouldn't have full control over reproducible results (e.g. having the same version of that dependency installed), plus a small time optimization that we're able to figure out if somepackage.jsonentries are missing, which we wouldn't notice on an implicit installation instead (#explicitvsimplicit).