-
Notifications
You must be signed in to change notification settings - Fork 9
fix: mainnavigation underneath 1024px viewports #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mainnavigation underneath 1024px viewports #1970
Conversation
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/1964-db-mainnavigation-is-completely-broken-below-1023-px-viewport |
…below-1023-px-viewport
…below-1023-px-viewport
|
any updates when this can be expected in a release? |
|
@mriehl we'd like to both clean up as well as resolve a lot of open issues within the backlog by concentrated attention in January. |
uhm okay. I would have expected this issue to be higher priority, since any page using DB elements is completely unusable on a smaller viewport (if using a menu). But I guess if there are more important things it will have to wait. It's quite difficult to explain to users who complain about the unusable navigation that I am using an official framework and it's simply broken upstream. |
Agreed. I actually don't know what kept us away from merging this earlier. Maybe there's still some outstanding issues, but this should serve quite well as fix for the moment without breaking anything, but actually fixing the problem itself. So I'll release this in the next half an hour. |
…below-1023-px-viewport
…below-1023-px-viewport
|
Thanks @mfranzke ! |
thanks for your feedback & reportings. |
Resolves #1964