Skip to content

Conversation

@mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 1, 2023

Resolves #1964

@mfranzke mfranzke added the bug Something isn't working label Nov 1, 2023
@mfranzke mfranzke added this to the Release 1.0 milestone Nov 1, 2023
@mfranzke mfranzke self-assigned this Nov 1, 2023
@mfranzke mfranzke linked an issue Nov 1, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

@mriehl
Copy link

mriehl commented Dec 13, 2023

any updates when this can be expected in a release?

@mfranzke
Copy link
Member Author

@mriehl we'd like to both clean up as well as resolve a lot of open issues within the backlog by concentrated attention in January.

@mriehl
Copy link

mriehl commented Dec 13, 2023

@mriehl we'd like to both clean up as well as resolve a lot of open issues within the backlog by concentrated attention in January.

uhm okay. I would have expected this issue to be higher priority, since any page using DB elements is completely unusable on a smaller viewport (if using a menu). But I guess if there are more important things it will have to wait.

It's quite difficult to explain to users who complain about the unusable navigation that I am using an official framework and it's simply broken upstream.

@mfranzke
Copy link
Member Author

mfranzke commented Dec 13, 2023

@mriehl we'd like to both clean up as well as resolve a lot of open issues within the backlog by concentrated attention in January.

uhm okay. I would have expected this issue to be higher priority, since any page using DB elements is completely unusable on a smaller viewport (if using a menu). But I guess if there are more important things it will have to wait.

It's quite difficult to explain to users who complain about the unusable navigation that I am using an official framework and it's simply broken upstream.

Agreed. I actually don't know what kept us away from merging this earlier. Maybe there's still some outstanding issues, but this should serve quite well as fix for the moment without breaking anything, but actually fixing the problem itself.

So I'll release this in the next half an hour.

@mfranzke mfranzke marked this pull request as ready for review December 13, 2023 13:59
@mfranzke mfranzke merged commit db24add into main Dec 13, 2023
@mfranzke mfranzke deleted the 1964-db-mainnavigation-is-completely-broken-below-1023-px-viewport branch December 13, 2023 14:24
@mriehl
Copy link

mriehl commented Dec 13, 2023

Thanks @mfranzke !

@mfranzke
Copy link
Member Author

Thanks @mfranzke !

thanks for your feedback & reportings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working stencil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db-mainnavigation is completely broken below 1023 px viewport

3 participants