Skip to content

feat(logo): integrate sizes and related pulse as an option for headlines #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 8, 2023
Merged

feat(logo): integrate sizes and related pulse as an option for headlines #570

merged 19 commits into from
Feb 8, 2023

Conversation

@mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 17, 2022 •
edited
Loading

  • Added logo component with sizes property, as this leads to the pulse size.
  • Added pulse property to headline.

@mfranzke mfranzke added enhancement New feature or request community feedback labels Nov 17, 2022
@mfranzke mfranzke added this to the Release 1.0 milestone Nov 17, 2022
@mfranzke mfranzke self-assigned this Nov 17, 2022
@mfranzke mfranzke linked an issue Nov 17, 2022 that may be closed by this pull request
feat(logo): integrate sizes and related pulse as an option for headlines #568
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/568-featlogo-integrate-sizes-and-related-pulse-as-an-option-for-headlines

@mfranzke mfranzke marked this pull request as draft November 18, 2022 13:30
nmerget
nmerget previously approved these changes Nov 21, 2022
View reviewed changes
@mfranzke mfranzke marked this pull request as ready for review February 7, 2023 13:36
@mfranzke mfranzke enabled auto-merge (squash) February 7, 2023 13:37
@mfranzke mfranzke requested a review from nmerget February 7, 2023 13:39
@nmerget
Copy link
Member

nmerget commented Feb 7, 2023

Can you add the logo to the angular showcase and add a cypress test for all the showcases https://github.com/db-ui/elements/blob/main/e2e/cypress/integration/99-1-showcases/showcases-other-elements.spec.js

@mfranzke
Copy link
Member Author

mfranzke commented Feb 7, 2023

Can you add the logo to the angular showcase and add a cypress test for all the showcases https://github.com/db-ui/elements/blob/main/e2e/cypress/integration/99-1-showcases/showcases-other-elements.spec.js

done

nmerget
nmerget previously approved these changes Feb 8, 2023
View reviewed changes
@mfranzke
Copy link
Member Author

mfranzke commented Feb 8, 2023

@nmerget fixed that aspect, thanks for the catch. Could you please reapprove ?

@mfranzke mfranzke merged commit 9b388bb into main Feb 8, 2023
@mfranzke mfranzke deleted the 568-featlogo-integrate-sizes-and-related-pulse-as-an-option-for-headlines branch February 8, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels

angular angular-showcase community feedback enhancement New feature or request react-showcase stencil vue-showcase

Projects

None yet

Milestone

Release 1.0

Development

Successfully merging this pull request may close these issues.

feat(logo): integrate sizes and related pulse as an option for headlines

3 participants

@mfranzke @nmerget