-
Notifications
You must be signed in to change notification settings - Fork 13
Labels
👩👧👦communityFeedbackFeedback from communityFeedback from community
Description
Which generators are affected?
- All
- HTML
- React
- Angular
- Vue
- Web components
- Power Apps
Reproduction case
The current implementation of px-to-rem() does not return a value but a string. I stumbled upon this issue while creating a very similar function in our code. The way it is currently implemented does not allow calculations with the value:
core-web/packages/foundations/scss/helpers/_functions.scss
Lines 5 to 7 in 8f07e55
| @function px-to-rem($pxValue) { | |
| @return #{$pxValue * 0.0625}rem; | |
| } |
Expected Behaviour
The return value should be a rem value, therefore the function neede to be adjusted in this way:
instead of: @return #{$pxValue * 0.0625}rem;
use this: @return ($pxValue * 0.0625) * 1rem;
For completeness, I also found it here: sass/sass#2356 (comment)
Screenshots
No response
Browser version
None
Add any other context about the problem here.
No response
Which DB business unit do you work for?
Delivery-Team Web Development 1 (TO.IP D-T-037)
”DB Systel” please enter your customer / ”other” please enter your area or business unit.
No response
What project are you working on?
No response
mfranzkeCopilot
Metadata
Metadata
Labels
👩👧👦communityFeedbackFeedback from communityFeedback from community
Type
Projects
Status
✅ Done