-
Notifications
You must be signed in to change notification settings - Fork 13
fix(custom-select): keyboard navigation for option groups in single-select mode #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e3a680c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…custom-select option groups Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
|
@copilot please remove the |
…mprehensive test Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
I've made the requested changes in commit 12ccbdb:
The critical test for issue #4920 is now part of the main test suite under "option groups keyboard navigation: should navigate between option groups correctly" which specifically validates that users can navigate from G1:Option 2 to G2:Option 1 using arrow keys - the exact issue that was previously broken. |
Run the test that has been developed within #4921 for our current code to verify it fails.
# Conflicts: # packages/components/src/components/custom-select/custom-select.spec.tsx
Pull request was converted to draft
# Conflicts: # .changeset/rare-pans-stare.md
waitForFocusChange()helper function usingpage.waitForFunction()waitForTimeout(1000)andwaitForTimeout(100)calls with proper state checkingSummary
The custom-select component had a keyboard accessibility issue where users could not navigate to options in subsequent option groups using arrow keys in single-select mode. Fixed by adding proper type checking to ensure "select all" logic only applies when there's actually a "select all" checkbox present.
Testing improvements:
waitForFocusChange()helper functionpage.waitForFunction()to wait for actual DOM state changesImpact:
Fixes #4920.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.