Skip to content

Conversation

@nmerget
Copy link
Collaborator

@nmerget nmerget commented Oct 6, 2025

Proposed changes

Add a preview URL only if the deployment was successful instead of adding a comment on opening the PR

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-preview-url

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 3572c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Oct 6, 2025
@nmerget nmerget self-assigned this Oct 6, 2025
@nmerget nmerget marked this pull request as ready for review October 6, 2025 09:08
@nmerget nmerget moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Oct 6, 2025
@nmerget nmerget moved this from 🎁 Ready for review to 🏗 In progress in UX Engineering Team Backlog Oct 6, 2025
@nmerget nmerget marked this pull request as draft October 6, 2025 09:08
@nmerget nmerget moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Oct 7, 2025
@nmerget nmerget marked this pull request as ready for review October 7, 2025 05:19
@nmerget nmerget enabled auto-merge (squash) October 7, 2025 05:19
@mfranzke
Copy link
Collaborator

mfranzke commented Oct 7, 2025

@nmerget As I understand it, the URL would be added to or replaced in the description after a successful deployment in each pipeline run. However, it wouldn't change over time because it's a consistent name. What would be the benefit of changing the current simple implementation to this more extended one, besides the timing of adding it after a successful deployment, and not already upfront? Our pages are always deployed to that URL, and if I want to ensure I get the latest deployment, I need to check the latest commit's green pipeline status anyhow.

(I'm not questioning the decision to move the URL from the comment to the PR description.)

@nmerget nmerget changed the title chore: add preview-url-pr-description to preview branch output chore: preview branch output inside description instead of comment Oct 7, 2025
@nmerget
Copy link
Collaborator Author

nmerget commented Oct 7, 2025

@nmerget As I understand it, the URL would be added to or replaced in the description after a successful deployment in each pipeline run. However, it wouldn't change over time because it's a consistent name. What would be the benefit of changing the current simple implementation to this more extended one, besides the timing of adding it after a successful deployment, and not already upfront? Our pages are always deployed to that URL, and if I want to ensure I get the latest deployment, I need to check the latest commit's green pipeline status anyhow.

(I'm not questioning the decision to move the URL from the comment to the PR description.)

Yes you are right, I think it is confusing to have a comment with a link which isn't available.

@michaelmkraus michaelmkraus moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Oct 7, 2025
@michaelmkraus michaelmkraus self-requested a review October 7, 2025 11:03
Co-authored-by: Michael Kraus <michael.m.kraus@deutschebahn.com>
michaelmkraus
michaelmkraus previously approved these changes Oct 7, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nmerget and others added 2 commits October 7, 2025 14:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nmerget nmerget disabled auto-merge October 7, 2025 14:19
@nmerget nmerget merged commit e6fd96f into main Oct 7, 2025
69 checks passed
@nmerget nmerget deleted the chore-preview-url branch October 7, 2025 14:19
@github-project-automation github-project-automation bot moved this from 👀 Actively In Review to ✅ Done in UX Engineering Team Backlog Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢📀cicd Changes inside .github folder

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants