-
Notifications
You must be signed in to change notification settings - Fork 13
chore: preview branch output inside description instead of comment #5140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
# Conflicts: # .github/workflows/99-add-url-comment.yml
…mprove readability
…mprove readability
|
@nmerget As I understand it, the URL would be added to or replaced in the description after a successful deployment in each pipeline run. However, it wouldn't change over time because it's a consistent name. What would be the benefit of changing the current simple implementation to this more extended one, besides the timing of adding it after a successful deployment, and not already upfront? Our pages are always deployed to that URL, and if I want to ensure I get the latest deployment, I need to check the latest commit's green pipeline status anyhow. (I'm not questioning the decision to move the URL from the comment to the PR description.) |
Yes you are right, I think it is confusing to have a comment with a link which isn't available. |
Co-authored-by: Michael Kraus <michael.m.kraus@deutschebahn.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Proposed changes
Add a preview URL only if the deployment was successful instead of adding a comment on opening the PR
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-preview-url