Skip to content

refactor reverted quick hacks #5303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

refactor reverted quick hacks #5303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c95102
Revert "Refactor deployment workflow by removing storybook downloads"
mfranzke Oct 17, 2025
a8f242d
Revert "Disable storybook build jobs in workflow"
mfranzke Oct 17, 2025
e04e210
Revert "fix: release pipeline as quick hack"
mfranzke Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/03-deploy-gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,38 @@ jobs:
name: db-ux-patternhub
path: build-showcases/patternhub

- name: ⏬ Download composition-storybook
uses: actions/download-artifact@v5
with:
name: db-ux-composition-storybook
path: build-storybooks/composition-storybook

- name: ⏬ Download angular-storybook
uses: actions/download-artifact@v5
with:
name: db-ux-angular-storybook
path: build-storybooks/angular-storybook

- name: ⏬ Download react-storybook
uses: actions/download-artifact@v5
with:
name: db-ux-react-storybook
path: build-storybooks/react-storybook

- name: ⏬ Download vue-storybook
uses: actions/download-artifact@v5
with:
name: db-ux-vue-storybook
path: build-storybooks/vue-storybook

- name: 🦵🦿 I like to move it move it
shell: bash
run: |
mv build-showcases/patternhub out
mv build-storybooks/composition-storybook out/composition-storybook
mv build-storybooks/angular-storybook out/angular-storybook
mv build-storybooks/react-storybook out/react-storybook
mv build-storybooks/vue-storybook out/vue-storybook

- name: 🔨 Build page
env:
Expand Down
63 changes: 35 additions & 28 deletions .github/workflows/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,34 +78,33 @@ jobs:
needs: [build-packages, init]
with:
version: ${{ needs.init.outputs.playwrightVersion }}

#build-storybook-composition:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: composition-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}

#build-storybook-angular:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: angular-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}

#build-storybook-react:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: react-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}

#build-storybook-vue:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: vue-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}
build-storybook-composition:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: composition-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

build-storybook-angular:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: angular-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

build-storybook-react:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: react-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

build-storybook-vue:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: vue-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

build-showcase-stencil:
uses: ./.github/workflows/01-build-showcases.yml
Expand Down Expand Up @@ -335,6 +334,10 @@ jobs:
steps:
- name: 🎉 Checks done
run: |
resultBuildStorybookComposition="${{ needs.build-storybook-composition.result }}"
resultBuildStorybookAngular="${{ needs.build-storybook-angular.result }}"
resultBuildStorybookReact="${{ needs.build-storybook-react.result }}"
resultBuildStorybookVue="${{ needs.build-storybook-vue.result }}"
resultBuildShowcaseStencil="${{ needs.build-showcase-stencil.result }}"
resultBuildShowcaseAngular="${{ needs.build-showcase-angular.result }}"
resultBuildShowcaseAngularSSR="${{ needs.build-showcase-angular-ssr.result }}"
Expand Down Expand Up @@ -381,6 +384,10 @@ jobs:
fi
needs:
[
build-storybook-composition,
build-storybook-angular,
build-storybook-react,
build-storybook-vue,
build-showcase-stencil,
build-showcase-angular,
build-showcase-angular-ssr,
Expand Down
56 changes: 32 additions & 24 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,33 +47,33 @@ jobs:
with:
version: ${{ needs.init.outputs.playwrightVersion }}

# build-storybook-composition:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}
build-storybook-composition:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

# build-storybook-angular:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: angular-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}
build-storybook-angular:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: angular-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

# build-storybook-react:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: react-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}
build-storybook-react:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: react-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

# build-storybook-vue:
# uses: ./.github/workflows/01-build-storybooks.yml
# needs: [build-packages, init]
# with:
# storybook: vue-storybook
# baseUrl: ${{ needs.init.outputs.baseUrl }}
build-storybook-vue:
uses: ./.github/workflows/01-build-storybooks.yml
needs: [build-packages, init]
with:
storybook: vue-storybook
baseUrl: ${{ needs.init.outputs.baseUrl }}

build-showcase-stencil:
uses: ./.github/workflows/01-build-showcases.yml
Expand Down Expand Up @@ -178,6 +178,10 @@ jobs:
steps:
- name: 🎉 Checks done
run: |
resultBuildStorybookComposition="${{ needs.build-storybook-composition.result }}"
resultBuildStorybookAngular="${{ needs.build-storybook-angular.result }}"
resultBuildStorybookReact="${{ needs.build-storybook-react.result }}"
resultBuildStorybookVue="${{ needs.build-storybook-vue.result }}"
resultBuildShowcaseStencil="${{ needs.build-showcase-stencil.result }}"
resultBuildShowcaseAngular="${{ needs.build-showcase-angular.result }}"
resultBuildShowcaseAngularSSR="${{ needs.build-showcase-angular-ssr.result }}"
Expand Down Expand Up @@ -224,6 +228,10 @@ jobs:
fi
needs:
[
build-storybook-composition,
build-storybook-angular,
build-storybook-react,
build-storybook-vue,
build-showcase-stencil,
build-showcase-angular,
build-showcase-angular-ssr,
Expand Down