Include 'time' Input Type #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcbegley
approved these changes
Jan 6, 2025
Collaborator
tcbegley
left a comment
tcbegley
left a comment
There was a problem hiding this comment.
Thanks, as you say this already works, these prop types are just used to generate documentation. Happy to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'time' input to
<input>use to not be supported by Safari, which is likely why it wasn't included to begin with (related Dash thread). However, as of Safari 14.1, it now has full support across all modern browers.I simply added it as a option to
Input.propTypes.type, but I see there are other areas where it could potentially be added (e.g.Input.propTypes.inputmode/inputMode).Using
dbc.Input(type="time")already works as expected, so I figured this just requires an update of the docs.