Skip to content

Update Card, Nav and Navbar for V5 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 20, 2021
Merged

Update Card, Nav and Navbar for V5 #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
748b3f5
Monkeypatch doc tests
tcbegley Aug 15, 2021
5e770fe
Card
AnnMarieW Aug 16, 2021
638fe7c
Merge branch 'react-bootstrap' of https://github.com/facultyai/dash-b…
AnnMarieW Aug 16, 2021
c96ccc7
Nav and NavBar Update to Collapse to remove navbar prop
AnnMarieW Aug 18, 2021
41c0b70
fixed Card.test.js for Card body test
AnnMarieW Aug 18, 2021
e7350ac
updated docs for Navbar example.
AnnMarieW Aug 18, 2021
6a99d14
updates to Navbar and Collapse after review
AnnMarieW Aug 19, 2021
a95718b
Merge branch 'react-bootstrap' of https://github.com/facultyai/dash-b…
AnnMarieW Aug 19, 2021
11679df
updated index for deleted NavbarCollapse
AnnMarieW Aug 19, 2021
238860a
lint and black
AnnMarieW Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions docs/components_page/components/card.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,8 @@ Use the `CardGroup` component to render cards as a single attached element with

{{example:components/card/layout/group.py:cards}}

### Card deck

The `CardDeck` component will lay cards out with equal width and height, without attaching them to one another like the `CardGroup` component.

{{example:components/card/layout/deck.py:cards}}

### Card columns

Cards can be organised into [Masonry](https://masonry.desandro.com/)-like columns using the `CardColumns` component. Cards are ordered top to bottom and left to right.

{{example:components/card/layout/columns.py:cards}}

{{apidoc:src/components/card/CardDeck.js}}

{{apidoc:src/components/card/CardGroup.js}}

{{apidoc:src/components/card/CardColumns.js}}

{{apidoc:src/components/card/Card.js}}

{{apidoc:src/components/card/CardHeader.js}}
Expand Down
61 changes: 0 additions & 61 deletions docs/components_page/components/card/layout/columns.R
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions docs/components_page/components/card/layout/columns.jl
View file
Open in desktop

This file was deleted.

61 changes: 0 additions & 61 deletions docs/components_page/components/card/layout/columns.py
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions docs/components_page/components/card/layout/deck.R
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions docs/components_page/components/card/layout/deck.jl
View file
Open in desktop

This file was deleted.

53 changes: 0 additions & 53 deletions docs/components_page/components/card/layout/deck.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions docs/components_page/components/navbar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ Here is an example of a custom navbar, see the `examples/` folder in the [GitHub
{{apidoc:src/components/nav/NavbarBrand.js}}

{{apidoc:src/components/nav/NavbarToggler.js}}

2 changes: 1 addition & 1 deletion docs/components_page/components/navbar/navbar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ navbar <- dbcNavbar(
dbcCol(dbcNavbarBrand("Navbar", class_name = "ms-2"))
),
align = "center",
no_gutters = TRUE
class_name="g-0"
),
href = "https://plotly.com"
),
Expand Down
2 changes: 1 addition & 1 deletion docs/components_page/components/navbar/navbar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ navbar = dbc_navbar(
href="https://plotly.com",
),
dbc_navbartoggler(id="navbar-toggler", n_clicks=0),
dbc_collapse(search_bar, id="navbar-collapse", navbar=true, is_open=false),
dbc_collapse(search_bar, id="navbar-collapse", is_open=false, navbar=true),
],
color="dark",
dark=true,
Expand Down
2 changes: 1 addition & 1 deletion docs/components_page/components/navbar/navbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
),
dbc.NavbarToggler(id="navbar-toggler", n_clicks=0),
dbc.Collapse(
search_bar, id="navbar-collapse", navbar=True, is_open=False
search_bar, id="navbar-collapse", is_open=False, navbar=True
),
],
color="dark",
Expand Down
2 changes: 1 addition & 1 deletion docs/demos/theme_explorer/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
cards = html.Div(
[
make_subheading("Card", "card"),
dbc.CardDeck(
dbc.CardGroup(
[
dbc.Card(
[
Expand Down
4 changes: 1 addition & 3 deletions examples/python/gallery/wordcloud/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,7 @@ def load_word_frequencies(book):
[
html.Div([dbc.Label("Choose a book:"), dropdown]),
html.Div([dbc.Label("Minimum frequency:"), min_freq_slider]),
html.Div(
[dbc.Label("Maximum number of words:"), max_vocab_slider]
),
html.Div([dbc.Label("Maximum number of words:"), max_vocab_slider]),
],
class_name="mb-3",
body=True,
Expand Down
Loading